Changes required to build with vbcc #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: Missing includes Missing OpenLibrarys Wrong types (mostly BPTR=NULL changed to 0) Bug in UnlockPubScreen Added makefile for vbcc The semicolon at the start of main.c needs to be removed for the makefile to work.
Author
|
Whilst it builds, there's something not quite right as it crashes if there is an ADF mounted. Investigating... |
Author
|
Fixed - you had a free() without a malloc() |
Author
|
Now part of PR #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Missing includes
Missing OpenLibrarys
Wrong types (mostly BPTR=NULL changed to 0)
Bug in UnlockPubScreen
Added makefile for vbcc
The semicolon at the start of main.c needs to be removed for the makefile to work (didn't want to leave it out as it would break "execute to compile")
I can't check if it still builds under SAS/C but it should do.
Suggestions:
I removed the .o and .lib files - would recommend to add a .gitignore to stop them being committed to the repo.
The functionLib would be better off in a subdir of src, then point everything at that dir, rather than copying the lib and include over.