Implement support for actionCreators #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Creator for each case of the Program's msg discriminated union
…tching the corresponding application message
et1975
approved these changes
May 12, 2025
Member
|
Looks good to me, @MangelMaxime any concerns? |
MangelMaxime
approved these changes
May 12, 2025
Member
|
Thanks, released as 4.2.2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #71 Redux DevTools allows triggering the actions defined in the config parameter
actionCreators.This is an array of POJOs with the fields
nameandargsused for building the UI for triggering the actions. Thename and the args' values are sent back to the application in a message with the field
typeset to ACTION.This PR extends Elmish Debugger to:
actionCreatorsparameter of the browser extensionReflection is used to dynamically populate
actionCreatorswith all the actions defined in the application and also to dynamically dispatch the action received from Redux DevTools. Since Fable erases generics at runtime the functionwithDebuggerUsinghas to be inlined so that the generics can be resolved at compile time.