Fix examples to use updated SignerClient constructor with api_private_keys#116
Open
Bvvvp009 wants to merge 1 commit intoelliottech:mainfrom
Open
Fix examples to use updated SignerClient constructor with api_private_keys#116Bvvvp009 wants to merge 1 commit intoelliottech:mainfrom
Bvvvp009 wants to merge 1 commit intoelliottech:mainfrom
Conversation
…_keys - Fix generate.py: Update SignerClient to use api_private_keys dict format - Fix onboard_direct.py: Remove broken fallback code using old constructor - Fix onboard_indirect.py: Remove broken fallback code using old constructor - Update setup.py: Already correct, includes multi-key support All examples now compatible with upstream SignerClient changes requiring api_private_keys dictionary instead of separate private_key and api_key_index parameters.
gioto64
reviewed
Jan 26, 2026
| if err is not None: | ||
| logging.error(err) | ||
| print(f"error: failed to setup account {sub_account.index}: {err}", file=sys.stderr) |
Contributor
There was a problem hiding this comment.
small nit
Suggested change
| print(f"error: failed to setup account {sub_account.index}: {err}", file=sys.stderr) | |
| print(f"Error: failed to setup account {sub_account.index}: {err}", file=sys.stderr) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed and Added :
All examples now compatible with upstream SignerClient changes requiring api_private_keys dictionary instead of separate private_key and api_key_index parameters.