fix: Change MarketIndex from uint8_t to int16_t to support spot markets#107
Closed
Bvvvp009 wants to merge 1 commit intoelliottech:mainfrom
Closed
fix: Change MarketIndex from uint8_t to int16_t to support spot markets#107Bvvvp009 wants to merge 1 commit intoelliottech:mainfrom
Bvvvp009 wants to merge 1 commit intoelliottech:mainfrom
Conversation
Fixes elliottech#106 Spot market orders (market_id >= 2048) were incorrectly routed to perps market 0 due to uint8_t overflow. The uint8_t type (max 255) was truncating spot market IDs (2048+) to 0. Updated CreateOrderTxReq struct MarketIndex field from uint8_t to int16_t in Python ctypes definition and all platform header files to match lighter-go sharedlib fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106
Spot market orders (market_id >= 2048) were incorrectly routed to perps market 0 due to uint8_t overflow. The uint8_t type (max 255) was truncating spot market IDs (2048+) to 0.
Updated CreateOrderTxReq struct MarketIndex field from uint8_t to int16_t in Python ctypes definition and all platform header files to match lighter-go sharedlib fix.