Skip to content

Beautify UI: New CSS rules (Fellow Contribution)#58

Open
kescardoso wants to merge 3 commits intoelleanne:mainfrom
kescardoso:main
Open

Beautify UI: New CSS rules (Fellow Contribution)#58
kescardoso wants to merge 3 commits intoelleanne:mainfrom
kescardoso:main

Conversation

@kescardoso
Copy link
Copy Markdown
Contributor

Fixed:

  • Nav elements
  • Header positioning
  • Logo dimensions and radius
  • Table headings
  • Footer and credit links

Screenshot 2021-04-20 at 19 34 45

Screenshot 2021-04-20 at 19 35 05

Screenshot 2021-04-20 at 19 35 28

Screenshot 2021-04-20 at 19 35 54

@kescardoso kescardoso mentioned this pull request Apr 20, 2021
Copy link
Copy Markdown
Collaborator

@sakshigupta265 sakshigupta265 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the new UI!

Copy link
Copy Markdown
Owner

@elleanne elleanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great!
@kescardoso the extension is complaining because it doesn't know fontawesome's content security policy. If you trust it, we can add it to the HTTP header with no problem. Have you used it before?

@kescardoso
Copy link
Copy Markdown
Contributor Author

@Eliboss I use font awesome in all of my projects https://fontawesome.com/
You already initially have a js script of fontawesome included in your templates:

https://github.com/eliboss/search-savior/blob/3cdef95e1f200fa4b3bb3910dd313ef95b67328b/projectpage/index.html#L24

I added the CSS script to beautify your github and goofy goofy icons on the footer:

https://github.com/kescardoso/search-savior/blob/5e8109cca5a1aa0e5d70ecea21bba0612f82aa0e/projectpage/index.html#L23

Font Awesome is a very safe script.

@elleanne
Copy link
Copy Markdown
Owner

@kescardoso lol, whoops. Sakshi did the UI. Cool, I'm good then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants