fix: Withings review follow-up (security + data correctness)#100
Open
marian001 wants to merge 2 commits intoelkimek:mainfrom
Open
fix: Withings review follow-up (security + data correctness)#100marian001 wants to merge 2 commits intoelkimek:mainfrom
marian001 wants to merge 2 commits intoelkimek:mainfrom
Conversation
|
@marian001 is attempting to deploy a commit to the elkimek's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Alright, I dust off my Oura, give me a week or two, I'll gather some data and do the wearables system properly then we can plug in Withings and others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up on feedback from #96 and implements the requested Withings fixes while keeping the existing biometrics UX work intact.
References:
What changed
Security
withings_*keys to sensitive storage patterns injs/crypto.jsencryptedSetItem/encryptedGetIteminitWithings()and call during startup to hydrate cached encrypted config before OAuth callback handlingAuthorization: Bearer <token>headeraccess_tokenquery parameter removedMath.random()state generation withcrypto.getRandomValues()meastype=1to request only weight from Withings APIFunctional/data fixes
js/biometrics-view.js, corrected weight row filtering so manual rows are preserved and Withings rows are the ones targeted when neededunit: 'kg'Minor consistency updates
saveWithingsCredentials()async to await encrypted save pathFiles changed
js/withings-weight.jsjs/crypto.jsjs/main.jsjs/biometrics-view.jsjs/settings.jsNotes