Limit negative focus outline-offset to elements that need it#2239
Merged
Conversation
Previously, all elements had the negative offset applied in order to allow borders to show in clipped-overflow ancestors, which adversely affected standard links in content and action icons. Renames navTabBorderWidth to borderWidth and uses where appropriate.
|
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/26000584961/artifacts/7045388522 |
josevalim
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, all elements had the negative offset applied in order to allow borders to show in clipped-overflow ancestors, which adversely affected standard links in content and action icons.
exdocs-focus-outline-offset.mp4
Also adjusts sidebar menu button padding so that the icon is centred.