Skip to content

Conversation

@sdn4z
Copy link
Collaborator

@sdn4z sdn4z commented Nov 7, 2025

Adds the option to display the output in a table

closes #392

@github-actions github-actions bot added feature and removed feature labels Nov 7, 2025
@sdn4z sdn4z marked this pull request as ready for review November 7, 2025 10:43
@sdn4z sdn4z requested a review from scastlara as a code owner November 7, 2025 10:43
@sdn4z
Copy link
Collaborator Author

sdn4z commented Nov 7, 2025

/lgtm review

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦉 lgtm Review

Score: Needs Work 🔧

🔍 Summary

Good work on this PR. The introduction of the --table option is a nice feature, and the refactoring of the run command improves the structure of the CLI module.

However, there are a few important issues to address before this can be merged:

  1. A critical piece of exception handling was removed during the refactoring. This is a regression that needs to be fixed to avoid unhandled crashes.
  2. The new tests for the table output should be more thorough. Please add assertions to check the content of the output, not just the exit codes.

I've left specific comments on these points. Once these are addressed, the PR should be in great shape.

More information
  • Id: ca3d28de386542d984d95240f0420aed
  • Model: gemini-2.5-pro
  • Created at: 2025-11-07T10:46:01.074719+00:00
Usage summary
  • Request count: 2
  • Request tokens: 36,601
  • Response tokens: 14,198
  • Total tokens: 50,799

See the 📚 lgtm-ai repository for more information about lgtm.

@github-actions github-actions bot added feature and removed feature labels Nov 7, 2025
@sdn4z sdn4z merged commit 93cea26 into elementsinteractive:main Nov 7, 2025
13 checks passed
@sdn4z sdn4z deleted the table branch November 7, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add --table option

1 participant