Cleanup handling of tab icons #969
Open
+30
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenemter
force-pushed
the
lenemter/cleanup-tab-icon
branch
from
e34b7dc to
893c2cc
Compare
danirabbit
requested changes
Dec 31, 2025
| tab.icon = null; | ||
| break; | ||
| case COMPLETED: | ||
| tab.icon = new ThemedIcon ("process-completed-symbolic"); |
Member
There was a problem hiding this comment.
Should we set needs attention while we're here?
https://valadoc.org/libadwaita-1/Adw.TabPage.needs_attention.html
Probably we should also set tooltip for a11y:
https://valadoc.org/libadwaita-1/Adw.TabPage.indicator_tooltip.html
| var notification = new Notification (notification_title); | ||
| notification.set_body (process); | ||
| notification.set_icon (process_icon); | ||
| notification.set_icon (notification_icon); |
Member
There was a problem hiding this comment.
Maybe we should do a TabState.to_icon ()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for #317