Skip to content

Build as Flatpak #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
jeremypw wants to merge 242 commits into
base: main
Choose a base branch
from
Draft

Build as Flatpak #917

jeremypw wants to merge 242 commits into from
+1,615 −945

Conversation

@jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Sep 11, 2025 •
edited
Loading

Attempt to flatpak Terminal Gtk4

Copies a fair amount of code from BlackBox for spawning commands on the host from within the sandbox, modified to fit in with existing Terminal code.

This is based on the Gtk4 port to minimize the diff, but is not intended to be merged before the port itself has been merged as quite substantial changes are required.

@jeremypw
Fix meson build
2015732
@jeremypw
Granite.Widgets -> Granite
f2ce414
@jeremypw
Hdy -> Adwaita
0e1fd23
@jeremypw
Gtk.RadioButton -> Gtk.CheckButton
54771c8
@jeremypw
Gtk.Bin -> Gtk.Widget
ab48642
@jeremypw
Gtk.Clipboard -> Gdk.Clipboard
e6c92a8
@jeremypw
Lose Gdk.Geometry
ccd7ffe
@jeremypw
Lose configure_event
76b054a
@jeremypw
Bind window properties to settings
9f6cbf2
@jeremypw
Use Gtk.DropTarget
8e43130
@jeremypw
GestureMultuPress -> GestureClick
2693045
@jeremypw
ColorButton -> ColorDialogButton
1124645
@jeremypw
Lose show_all ()
91f6eba
@jeremypw
color_set -> notify["rgba"]
2ab2e81
@jeremypw
Supply Gtk.ColorDialog; lose use_alpha
584e824
@jeremypw
Lose destroy.connect
349793b
@jeremypw
Lose get_style_context ()
8736d45
@jeremypw
Further fix style_context
f6b1bbc
@jeremypw
add () -> append ()
e538994
@jeremypw
Fix DESTRUCTIVE_ACTION style
4435b25
@jeremypw
Fix LINKED style
6d2087d
@jeremypw
Fix Gtk.STYLE_CLASS_TITLE
b72e613
@jeremypw
Fix incorrect return in DND
e47405c
@jeremypw
Fix fullscreen
1b34a4a
@jeremypw
Fix invalid members
e23c76b
@jeremypw
Lose Gdk.Screen
d8835f2
@jeremypw
Fix some non-existent function/signals
4788137
@jeremypw
Fix some more non-existent things in MainWindow
7eedd2d
@jeremypw
Fix more non-existent in MainWindow
e84efd6
@jeremypw
Fix more non-exist in MainWindow
2fd5733
@jeremypw
Fix respawn due to extraneous LF from flatpak util
443a561
@jeremypw
Fix and simplify reload action
a81b338
@jeremypw
Sanitize when needed when getting selection or link.
7a92f56
@jeremypw
Do not assume complete uri when getting default app info for uri
0cb216e
@jeremypw
Remove commented out code
da10c28
@jeremypw
Merge branch 'jeremypw/fix-launch-browser' into gtk4/flatpak
c8acc38 
# Conflicts:
#	src/MainWindow.vala
@jeremypw
Bump min Vte version to 0.76
0ef43f5
@jeremypw
Use new builtin Vte context_menu_model property
d932758
@jeremypw
Fix get value from clipboard content provider
534ea85
@jeremypw
Fix getting value from primary selection
f8e9517
@jeremypw
Check confirmed in reset and reload actions
e7a7698
@jeremypw
Check confirmed in reset and reload actions
770f0d9
@jeremypw
Lose unused var
6b5b91f
@jeremypw
Kill fg and clear screen when resetting
d2451c4
@jeremypw
Reduce Platform version to 8.1 to avoid cli spam
68828ba
@jeremypw
Merge branch 'jeremypw/gtk4' into gtk4/flatpak
9a8ea6a
@jeremypw
Merge branch 'master' into jeremypw/gtk4
4eba743
@jeremypw
Merge branch 'jeremypw/gtk4' into gtk4/flatpak
9416ede
@jeremypw
Revert unneeded changes
85c76e7
@jeremypw
Merge branch 'jeremypw/gtk4' of https://github.com/elementary/terminal …
3ce35b5 
…into jeremypw/gtk4
@jeremypw
More concise Shortcut construction
13bba65
@jeremypw
Merge branch 'jeremypw/gtk4' into gtk4/flatpak
be99b00
@jeremypw
Modify comment
b938aa5
@jeremypw
Merge branch 'jeremypw/gtk4' into gtk4/flatpak
086c26a
@jeremypw
Copy link
Collaborator Author

jeremypw commented Sep 25, 2025 •
edited
Loading

Something in the 7.1.2 release causes errors in flatpak-builder 😞 -

Running appstreamcli compose
Only accepting components: io.elementary.terminal, io.elementary.terminal.desktop
Processing directory: /home/jeremy/Elementary/terminal/.flatpak-builder/rofiles/rofiles-k3Bsjn/files
Composing metadata...
Run failed, some data was ignored.
Errors were raised during this compose run:
io.elementary.terminal
  E: icon-not-found

general
  E: filters-but-no-output
Refer to the generated issue report data for details on the individual problems.
Error: ERROR: appstreamcli compose failed: Child process exited with code 1

@jeremypw
Copy link
Collaborator Author

jeremypw commented Sep 25, 2025

For some reason reverting to using @BASENAME@ for the output filename for the metainfo fixes the Flatpak build issue.

Base automatically changed from jeremypw/gtk4 to master November 17, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeremypw @danirabbit