Closed
Conversation
# Conflicts fixed: # src/View/Widgets/AppMenu.vala
Contributor
Author
|
Closing as this now only fixes a very corner issue - the dateformat buttons updating when the setting is changed externally (e.g. with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing to temporary settings object introduced a regression as they have signal handlers attached. The default button label did not update when the zoom change buttons were used.
It was also noticed that the zoom buttons were not correct if the menu was re-opened after switch to a different tab with a different viewmode/zoom-level. This bug was found to be pre-existing but was fixed here anyway.
It was noticed that it is not now necessary for the toplevel to update the view-mode even if the menu is not open and the relevant code was moved inside the AppMenu. This is pretty much the same as #2731