Skip to content

AppMenu: Fix regression and another issue#2742

Closed
jeremypw wants to merge 2 commits intomainfrom
jeremypw/appmenu/fix-zoom-regression
Closed

AppMenu: Fix regression and another issue#2742
jeremypw wants to merge 2 commits intomainfrom
jeremypw/appmenu/fix-zoom-regression

Conversation

@jeremypw
Copy link
Contributor

@jeremypw jeremypw commented Feb 11, 2026

Changing to temporary settings object introduced a regression as they have signal handlers attached. The default button label did not update when the zoom change buttons were used.

  • Persist settings as static objects

It was also noticed that the zoom buttons were not correct if the menu was re-opened after switch to a different tab with a different viewmode/zoom-level. This bug was found to be pre-existing but was fixed here anyway.

  • Set up the buttons every time the popup menu is opened.

It was noticed that it is not now necessary for the toplevel to update the view-mode even if the menu is not open and the relevant code was moved inside the AppMenu. This is pretty much the same as #2731

@jeremypw
Copy link
Contributor Author

Closing as this now only fixes a very corner issue - the dateformat buttons updating when the setting is changed externally (e.g. with dconf-editor or another Files Window) and the AppMenu does not play well with multiple windows anyway.

@jeremypw jeremypw closed this Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant