Skip to content

Window: use settings action for show-hidden#2734

Merged
jeremypw merged 3 commits intomainfrom
danirabbit/showhiddenaction
Feb 12, 2026
Merged

Window: use settings action for show-hidden#2734
jeremypw merged 3 commits intomainfrom
danirabbit/showhiddenaction

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Feb 10, 2026

Use a settings action instead of creating an action and syncing it to gsettings manually

@danirabbit danirabbit force-pushed the danirabbit/showhiddenaction branch from 879dee6 to b0ef50e Compare February 10, 2026 18:38
@danirabbit danirabbit requested a review from jeremypw February 10, 2026 18:39
@danirabbit
Copy link
Member Author

Not sure what that extra action in abstract directory view was about? Any insights @jeremypw? I think it would clean up things a lot to use Settings Actions

@danirabbit danirabbit marked this pull request as ready for review February 10, 2026 18:40
@jeremypw
Copy link
Contributor

Not sure what that extra action in abstract directory view was about? Any insights @jeremypw? I think it would clean up things a lot to use Settings Actions

Presumably at the time it was thought easier to keep the same pattern as the other context menu linked actions whereas the toplevel one was for dealing with the accelerator. I certainly agree Settings Actions, created where needed, should be used now. Not sure when they came in, but they seem to have passed me by up to now 😞 .

@danirabbit
Copy link
Member Author

I learned about this recently as well!

@danirabbit

This comment was marked as resolved.

@danirabbit danirabbit marked this pull request as draft February 11, 2026 17:56
@danirabbit danirabbit force-pushed the danirabbit/showhiddenaction branch from fe78e96 to febb5bb Compare February 11, 2026 18:03
@danirabbit danirabbit marked this pull request as ready for review February 11, 2026 18:03
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No regressions found

@jeremypw jeremypw merged commit 5a11ecd into main Feb 12, 2026
4 checks passed
@jeremypw jeremypw deleted the danirabbit/showhiddenaction branch February 12, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants