ChooseProjectButton: fix shortcut for Open Folder#1626
ChooseProjectButton: fix shortcut for Open Folder#1626
Conversation
| action_name = Scratch.MainWindow.ACTION_PREFIX + Scratch.MainWindow.ACTION_OPEN_FOLDER, | ||
| action_target = new Variant.string (""), | ||
| icon_name = "folder-open-symbolic", | ||
| accel_string = Scratch.MainWindow.ACTION_OPEN_FOLDER_ACCEL |
There was a problem hiding this comment.
This seems like a workaround for a bug in accel label. We should probably fix the bug instead
| } | ||
| }); | ||
|
|
||
| bind_property ("action-name", label, "action-name"); |
There was a problem hiding this comment.
Instead of removing this we should probably add an action_target property to accel label
There was a problem hiding this comment.
Probably, but Code is still using the Gtk3 Granite library - is this still being developed?
|
Coverting to draft pending changes to Granite.AccelLabel |
|
Clearing milestone as it is uncertain when or if suggested changes to Granite will be made. |
|
i think we should fix this first for current Granite and release ASAP. And when the changes in Granite are made, make the definitive patch. ( Add a comment in code to remind to fix this?) |
|
I don't like that the UI contains a shortcut that does not work. If we are not going to fix it in the short term then it should be removed from the menu option and a reminder comment inserted in the code. |
|
Going to close this and start a new one if required. |
3 participants
Fixes issues found in unreleased commit 34b0af4
There doesn't seem to be an elegant way for the chooser button to get the required accelerator from the MainWindow actiongroup so it exposed as a const string in MainWindow. If there is a better way please advise.