Skip to content

Comments

CloneRepositoryDialog: design tweaks#1584

Merged
jeremypw merged 1 commit intojeremypw/implement-clonefrom
danirabbit/implement-clone
May 30, 2025
Merged

CloneRepositoryDialog: design tweaks#1584
jeremypw merged 1 commit intojeremypw/implement-clonefrom
danirabbit/implement-clone

Conversation

@danirabbit
Copy link
Member

Screenshot from 2025-05-29 19 01 54

Simplify things a bit:

  • Set dialog modal. Happy to revert if it was intentional, but seems like we wouldn't want to spawn a bunch of the same dialog?
  • Simplify placeholder text a big. example.com is reserved for examples
  • Remove the folder image. This is a bit misleading as it looks like it's going to reflect the icon associated with the location but it always looks like the downloads folder
  • Change the ellipsis icon to folder-open to better communicate what will happen when it's pressed
  • Remove redundant headers
  • Reduce margins
  • Change from "URI" to "URL" since we specifically expect an http URL and not any resource location
  • "Parent folder of clone" seems clunky. GNOME Builder just uses "Location" and that seems fine to me 🤷‍♀️

@danirabbit danirabbit requested a review from jeremypw May 30, 2025 02:07
@jeremypw jeremypw merged commit 7cadd28 into jeremypw/implement-clone May 30, 2025
6 checks passed
@jeremypw jeremypw deleted the danirabbit/implement-clone branch May 30, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants