Skip to content

Comments

Move buttons from actionbar to projectchooser#1583

Merged
jeremypw merged 4 commits intojeremypw/implement-clonefrom
danirabbit/implement-clone-move-buttons
May 30, 2025
Merged

Move buttons from actionbar to projectchooser#1583
jeremypw merged 4 commits intojeremypw/implement-clonefrom
danirabbit/implement-clone-move-buttons

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented May 30, 2025

Closes #1581

Screenshot from 2025-05-29 18 34 42

Create a widget instead of using a util.

  • Set css name to make sure this is styled as a model button (highlight on hover etc)
  • Set the correct accessible role.
  • Reverts back to "Open Folder..." as the label for the open button
  • more descriptive "Clone Git Repository" since "Clone" is probably not descriptive enough, especially for blind folks
  • Add symbolic git icon
  • Button closes popover
  • Use AccelLabel in case we add accels to this later 🤷‍♀️ and for alignment etc

@danirabbit danirabbit requested a review from jeremypw May 30, 2025 01:42
@jeremypw jeremypw merged commit 2c315a2 into jeremypw/implement-clone May 30, 2025
6 checks passed
@jeremypw jeremypw deleted the danirabbit/implement-clone-move-buttons branch May 30, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants