patch: also log ERROR_INVALID_PARAMETER retries to stderr#2
Merged
MarshallOfSound merged 1 commit intomainfrom Apr 8, 2026
Merged
patch: also log ERROR_INVALID_PARAMETER retries to stderr#2MarshallOfSound merged 1 commit intomainfrom
MarshallOfSound merged 1 commit intomainfrom
Conversation
clog.Warningf only reaches the glog .WARNING/.INFO files because glog's default stderrThreshold is ERROR, so the retry was invisible in CI step output. Add an explicit fmt.Fprintf(os.Stderr, ...) alongside it so the retry is observable in the GitHub Actions console.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clog.Warningfonly reaches the glog.WARNING/.INFOfiles because glog's defaultstderrThresholdisERROR, so the retry was invisible in CI step output — confirmed by zeroW####lines in the Windows build console logs on electron/electron#50823.This adds an explicit
fmt.Fprintf(os.Stderr, …)alongside the existingclog.Warningfso retries show up in the GitHub Actions console as:Once merged, tag
v1.5.7-electron.2and bumpELECTRON_SISO_SHA256inelectron/electron.github/actions/install-build-tools/action.yml.