Skip to content

Conversation

@bitdisaster
Copy link
Contributor

@bitdisaster bitdisaster commented Aug 21, 2025

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

@bitdisaster bitdisaster marked this pull request as ready for review August 21, 2025 22:54
@bitdisaster bitdisaster requested a review from a team as a code owner August 21, 2025 22:54
@erickzhao erickzhao changed the title feat(msix maker): a forge maker for electron-windows-msix feat(msix): a forge maker for electron-windows-msix Aug 25, 2025
erickzhao
erickzhao previously approved these changes Aug 28, 2025
@erickzhao erickzhao dismissed their stale review September 2, 2025 18:35

Pending @electron/windows-sign support

@socket-security
Copy link

socket-security bot commented Sep 5, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedelectron-windows-msix@​2.0.47810010093100

View full report

@erickzhao erickzhao self-requested a review September 8, 2025 16:59
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will leave final sign off to @erickzhao

* introduces a maker that can create MSIX packages for DDL and Store deployment

fix: linter error

test: unit test and maker test inclusion

fix: update dependency after master merge

fix: arch test

fix: package not optional, don't return cert as artifact

Update packages/maker/msix/package.json

Co-authored-by: Erick Zhao <erick@hotmail.ca>

Update packages/maker/msix/README.md

Co-authored-by: Erick Zhao <erick@hotmail.ca>

don't return cert here

fix: msix packager without rx-js

fix: switiching to @malept/cross-spawn-promise

feat: add debug module support

fix: remove unsupported forge archs

prettier 3 formatting

remove invalid x86 input arch

refactor: deduplicate author name util

uniformize debug implementations

fix test

more test fix

fix: arch test

fix: `appDir` and `outputDir` are set by Forge

feat: new msix packager using @electron/windows-sign

fix: linter

fix: dynamic import ESM module

fix: debug failure in CI

fix: update packager

fix: oops

fix: update msix packager

fix: remove debug output

fix: new packager version respects windows-sign environment variables

Update dependencies to version 7.9.0

mark stuff as experimental
@erickzhao erickzhao changed the title feat(msix): a forge maker for electron-windows-msix feat(msix): add maker-msix Oct 8, 2025
@MarshallOfSound MarshallOfSound merged commit 5ca3bdd into electron:main Oct 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Add MSIX Maker Support

3 participants