-
-
Notifications
You must be signed in to change notification settings - Fork 610
feat(msix): add maker-msix #3978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
erickzhao
reviewed
Aug 25, 2025
erickzhao
reviewed
Aug 26, 2025
erickzhao
reviewed
Aug 26, 2025
erickzhao
reviewed
Aug 27, 2025
erickzhao
previously approved these changes
Aug 28, 2025
Pending @electron/windows-sign support
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
MarshallOfSound
approved these changes
Oct 8, 2025
Member
MarshallOfSound
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will leave final sign off to @erickzhao
erickzhao
approved these changes
Oct 8, 2025
* introduces a maker that can create MSIX packages for DDL and Store deployment fix: linter error test: unit test and maker test inclusion fix: update dependency after master merge fix: arch test fix: package not optional, don't return cert as artifact Update packages/maker/msix/package.json Co-authored-by: Erick Zhao <erick@hotmail.ca> Update packages/maker/msix/README.md Co-authored-by: Erick Zhao <erick@hotmail.ca> don't return cert here fix: msix packager without rx-js fix: switiching to @malept/cross-spawn-promise feat: add debug module support fix: remove unsupported forge archs prettier 3 formatting remove invalid x86 input arch refactor: deduplicate author name util uniformize debug implementations fix test more test fix fix: arch test fix: `appDir` and `outputDir` are set by Forge feat: new msix packager using @electron/windows-sign fix: linter fix: dynamic import ESM module fix: debug failure in CI fix: update packager fix: oops fix: update msix packager fix: remove debug output fix: new packager version respects windows-sign environment variables Update dependencies to version 7.9.0 mark stuff as experimental
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes: