feat: replace simple-git with octokit to load fiddle#50
Open
aryanshridhar wants to merge 1 commit intoelectron:mainfrom
Open
feat: replace simple-git with octokit to load fiddle#50aryanshridhar wants to merge 1 commit intoelectron:mainfrom
aryanshridhar wants to merge 1 commit intoelectron:mainfrom
Conversation
aryanshridhar
force-pushed
the
Add-Octokit
branch
from
1db31f2 to
c2eee3e
Compare
Contributor
Author
|
Ready for first round of review @dsanders11 :) |
|
I think it's okay if file other than VALID_FILES is being pushed to the contents too. The original Electron Fiddle app allows any other files to be pulled from the gist by prompting if the user wants to add that file first before adding in to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODOs
Fix all TODOs in codebase.Write testsFixes #38