Open
Conversation
…d [google-default-arguments]
…e-readability-casting] CFLocaleGetValue already returns CFTypeRef so that redundant static_cast was removed
Looks like clang-tidy couldn't tell these were two mutually exclusive branches so there was no actual issue, but refactoring is cleaner anyway since it makes it more DRY.
…lity-casting] No cast needed here, everything is already the correct type
dsanders11
added
semver/none
target/42-x-y
dsanders11
force-pushed
the
chore/clang-tidy-cleanups
branch
from
2d5c44c to
3d94f67
Compare
…terpret_cast [google-readability-casting]
dsanders11
force-pushed
the
chore/clang-tidy-cleanups
branch
from
3d94f67 to
7adcfe1
Compare
ckerr
reviewed
Apr 9, 2026
Comment on lines
+205
to
+206
| for (auto* notify_icon : notify_icons_) { | ||
| auto* current_win_icon = static_cast<NotifyIcon*>(notify_icon); |
Member
There was a problem hiding this comment.
Suggested change
| for (auto* notify_icon : notify_icons_) { | |
| auto* current_win_icon = static_cast<NotifyIcon*>(notify_icon); | |
| for (const auto* notify_icon : notify_icons_) { | |
| const auto* current_win_icon = static_cast<NotifyIcon*>(notify_icon); |
Member
Author
There was a problem hiding this comment.
Made this change, and I tweaked this a bit further, since I realized that the fixit from clang-tidy here was a bit too mechanical. Once we switched to the range-based for loop we don't need the static_cast line at all.
dsanders11
force-pushed
the
chore/clang-tidy-cleanups
branch
from
4499a5d to
5e7689c
Compare
dsanders11
added
the
target/41-x-y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This cleans up warnings from
clang-tidythat came out of #50771, on macOS and Windows.These are pretty straight forward, and I had Claude double check it.
Checklist
Release Notes
Notes: none