fix: remove decorateURL from default_app#50852
Merged
Conversation
mlaurencin
changed the title
mlaurencin
added
semver/patch
codebytere
force-pushed
the
remove-decorateURL
branch
from
48d161a to
8830ef0
Compare
codebytere
approved these changes
Apr 10, 2026
ckerr
approved these changes
Apr 10, 2026
|
No Release Notes |
This was referenced Apr 10, 2026
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #50897 |
trop
bot
added
in-flight/42-x-y
and removed
target/42-x-y
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #50898 |
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #50899 |
trop
bot
added
in-flight/41-x-y
in-flight/40-x-y
and removed
target/41-x-y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
With the most recent change to the default app (#45392), the two links below were generated. Due to having
?utm_source=default_appappended to them, both are not correctly resolved. This PR simply removes the function that adds that parameter. CC’ing the security working group since they were also CC’ed when this function was first introduced with a list of other changes that were noted as security-related. Alternatively, if there is a security reason to keep the function, I could update this PR to allow a way to indicate that the parameter should not be added to a given url.cc @electron/wg-security
Checklist
npm testpassesRelease Notes
Notes: none