This repository was archived by the owner on Jun 17, 2020. It is now read-only.
Don't save the response if HTTP response is not OK#38
Open
juturu wants to merge 1 commit intoelectron-userland:masterfrom
Open
Don't save the response if HTTP response is not OK#38juturu wants to merge 1 commit intoelectron-userland:masterfrom
juturu wants to merge 1 commit intoelectron-userland:masterfrom
Conversation
Author
|
@paulcbetts @zeke @felixrieseberg @MarshallOfSound can you please help review this PR? |
|
Hi @juturu! I'm not familiar with this library. Are you able to add a test for this scenario? |
Author
|
@zeke there are no existing tests for this part of the module. |
Author
|
@CharlieHess @felixrieseberg please help with this. |
|
@paulcbetts is the only npm owner. @paulcbetts would you be willing to |
Author
|
@paulcbetts can you help with this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: If the HTTP response is not 200, file is downloaded with the HTTP response text in it.
Fix: Stopping the file write if the response is not OK.