This repository was archived by the owner on Jun 17, 2020. It is now read-only.
Added support for promises in executeMainProcessMethod#30
Open
jcabot21 wants to merge 1 commit intoelectron-userland:masterfrom
Open
Added support for promises in executeMainProcessMethod#30jcabot21 wants to merge 1 commit intoelectron-userland:masterfrom
jcabot21 wants to merge 1 commit intoelectron-userland:masterfrom
Conversation
|
I implemented this patch manually in my app's code since I was running into the exact issue described in #29, rendering my code useless, and these proposed changes resolved the issue. I have not found any regressions so far in usage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #29 by behaving like
evalRemoteMethod.