This repository was archived by the owner on Oct 2, 2020. It is now read-only.
typescript+babel and coverage improvements#77
Open
fasterthanlime wants to merge 5 commits intoelectron-userland:masterfrom
Open
typescript+babel and coverage improvements#77fasterthanlime wants to merge 5 commits intoelectron-userland:masterfrom
fasterthanlime wants to merge 5 commits intoelectron-userland:masterfrom
Conversation
See electron-userland#76 - Drop istanbul@0.4.5 dependency, add babel-plugin-istanbul - Add getEnv() helper to SimpleCompilerBase - Support an environment string in the `coverage` option for both typescript and babel compilers - Make babel compiler use compilerContext as compile options - Drop sorcery dependency, pass inputSourceMap to babel instead - Always use babel+babel-plugin-istanbul to instrument code for measuring coverage - In ts+babel, translate ts sourcemap options to babel. With a twist, for inline sourcemaps.
11 tasks
Contributor
Author
|
Quick update: using |
Contributor
Author
Fixed in 262476a |
Contributor
Author
|
Another quick change I'm about to make: forward It's not possible to use the |
…ions (like include & exclude)
Contributor
Author
|
Latest semantics:
|
Contributor
Author
|
New find! While babel:
...if you specify |
…, so, do it ourselves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #76
coverageoption for both typescript and babel compilersinline sourcemaps.