This repository was archived by the owner on Oct 2, 2020. It is now read-only.
Open
Conversation
Author
|
@paulcbetts @saschagehlich do you think you could review these changes? |
Fix electron-compilers sass for both electron runtime and compile
Contributor
|
Sorry man, I'm not responsible for this repository. :( |
|
@alexstrat I'm not a contributor here, the paths fix is simple enough, but the second change doesn't seem as obvious to me. Is the current code removing /sass/ from the path, even when it isn't supposed to? It may be beneficial to have that as a separate request-- but I'm not responsible for this repository, either. |
|
This should fix nested imports, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pathsis not a valid option to pass tosass.js(see Add support for SassincludePathsoption #55 (comment)) -> remove it before passing compilerOptions tosass.jsThose 2 fixes worked on my project.