This repository was archived by the owner on Oct 2, 2020. It is now read-only.
Replace x-require src value with relative path instead of absolute#18
Open
jgeurts wants to merge 2 commits intoelectron-userland:masterfrom
jgeurts:master
Open
Replace x-require src value with relative path instead of absolute#18jgeurts wants to merge 2 commits intoelectron-userland:masterfrom jgeurts:master
jgeurts wants to merge 2 commits intoelectron-userland:masterfrom
jgeurts:master
Conversation
Contributor
|
I don't think this is right? But I don't remember how x-require works, so I have to look into it. I'll try to fix the underlying bug |
Author
|
Yeah, it seemed like a hack to me too, but it fixed the issue I was having and I hoped it would help others. If I can help at all as you dig into things, please let me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17