Feature: Midi - make it possible to handle 'SystemRealTime' events synchronously #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@HeckHeckHeckHeck with your digging into midi clock, do you have any thoughts on this issue? |
Author
|
its just a "back of the envelope" design suggestion prototype. Works for me (perfectly actually). |
|
+1 on this -- I've been ripping my hair out why my Seed inexplicably thought my MIDI channel was switching to 9 spontaneously. I just wrote my own fix at master...TomFrost:libDaisy:fix/midi-parser-running-status to detect the RTClock message before the parser resets. I should have looked here first. IMO @HeckHeckHeckHeck 's solution is more elegant, but I'll keep mine here for reference if it's worthwhile to anyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync more precisely to a Midi clock signal.