Skip to content

feat(sync-service): hibernate before suspend to enable GC #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alco wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

feat(sync-service): hibernate before suspend to enable GC #4284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ca99a96
feat(sync-service): add shape_suspend_after configuration
alco May 6, 2026
fd06de5
feat(sync-service): add suspend_timer and suspend_after to Consumer.S…
alco May 6, 2026
f51310d
feat(sync-service): implement hibernate-then-suspend in Consumer
alco May 6, 2026
2d2d934
feat(sync-service): update enable_suspend to include suspend_after
alco May 6, 2026
36196ae
test(sync-service): add tests for hibernate-then-suspend behavior
alco May 6, 2026
c07bffc
docs(sync-service): clarify hibernate/suspend config comments
alco May 6, 2026
af133ad
chore: add changeset for hibernate-then-suspend
alco May 6, 2026
95f64e7
fix(sync-service): address review feedback
alco May 6, 2026
5352e2d
fix(integration-tests): set ELECTRIC_SHAPE_SUSPEND_AFTER in suspensio…
alco May 7, 2026
b8544a5
wip implementation plan
alco May 12, 2026
fe0cbe4
Fix formatting in tests
alco May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hibernate-then-suspend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@core/sync-service': minor
---

Add hibernate-then-suspend behavior for Consumer processes. When suspend is enabled, consumers now hibernate first (triggering GC) before suspending. Adds `shape_suspend_after` config (default 60s) to control the delay between hibernation and suspension. Any activity cancels the pending suspend timer, restarting the cycle.
2 changes: 1 addition & 1 deletion integration-tests/tests/shape-suspension-resumption.lux
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

# Start Electric and wait for it to finish initialization.
# Set a very small hibernation timeout so consumers will shutdown quickly
[invoke setup_electric_with_env "ELECTRIC_SHAPE_HIBERNATE_AFTER=200ms ELECTRIC_SHAPE_SUSPEND_CONSUMER=true"]
[invoke setup_electric_with_env "ELECTRIC_SHAPE_HIBERNATE_AFTER=200ms ELECTRIC_SHAPE_SUSPEND_AFTER=200ms ELECTRIC_SHAPE_SUSPEND_CONSUMER=true"]
[shell electric]
[timeout 10]
??[debug] Replication client started streaming
Expand Down
Loading
Loading