Add support for react hook enabled flag#4071
Open
doanhtu07 wants to merge 1 commit intoelectric-sql:mainfrom
Open
Add support for react hook enabled flag#4071doanhtu07 wants to merge 1 commit intoelectric-sql:mainfrom
doanhtu07 wants to merge 1 commit intoelectric-sql:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Hi all, I was playing around with ElectricSQL and noticed that it couldn't stop polling even when a React component already unmounted.
Then, I saw your text on the main doc here: https://electric-sql.com/docs/integrations/react#how-to-abort-a-shape-subscription-%E2%80%94-abortcontroller
I also found this issue: #2212
How this solution works
packages/typescript-client/src/shape.tspackages/typescript-client/src/client.tspauseandresumeactionspackages/react-hooks/src/react-hooks.tsxNotes
Let me know what you think
Note that I've not worked on the second half of issue 2212