[wip]: Speed up shutdown by brutally killing snapshot processes#3756
Draft
magnetised wants to merge 5 commits intomainfrom
Draft
[wip]: Speed up shutdown by brutally killing snapshot processes#3756magnetised wants to merge 5 commits intomainfrom
magnetised wants to merge 5 commits intomainfrom
Conversation
❌ 55 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
6037b8a to
4168319
Compare
2b93719 to
f650b8a
Compare
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Comment |
Contributor
|
Found 110 test failures on Blacksmith runners: Failures
|
msfstef
reviewed
Jan 22, 2026
| # need to call `super()` to obtain the original DynamicSupervisor child_spec() to pass as an option to | ||
| # PartitionSupervisor. | ||
| PartitionSupervisor.child_spec( | ||
| child_spec: Supervisor.child_spec(super(opts), shutdown: :brutal_kill), |
Contributor
There was a problem hiding this comment.
can we not specify this shutdown policy on the snapshotter genserver?
31df264 to
0d4debb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.