Detect button::BODY_OUTLINE reliably.#154
Merged
adrian-sarmas merged 1 commit intoelearningsoftware:masterfrom Jan 21, 2026
Merged
Detect button::BODY_OUTLINE reliably.#154adrian-sarmas merged 1 commit intoelearningsoftware:masterfrom
adrian-sarmas merged 1 commit intoelearningsoftware:masterfrom
Conversation
Collaborator
|
Thanks @lucaboesch ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately @adrian-sarmas, pardon me,
if (defined('button::SECONDARY_OUTLINE')) {wasn't the right choice. It prevented fails for Moodle versions without that class and constant but more correct it would have beenif (class_exists(button::class) && (new \ReflectionClass(button::class))->hasConstant('SECONDARY_OUTLINE'))