chore: fix Rust 1.86 type inference and update to Rust 1.86#166
Open
beanow-at-crabnebula wants to merge 2 commits intoelastio:masterfrom
Open
chore: fix Rust 1.86 type inference and update to Rust 1.86#166beanow-at-crabnebula wants to merge 2 commits intoelastio:masterfrom
beanow-at-crabnebula wants to merge 2 commits intoelastio:masterfrom
Conversation
Author
|
As a quick summary from the upstream bug report. Implementing unstable feature flags for new trait impls is complicated, so it's a known issue that they appear in stable Rust. In this case it did as well, and causes type inference regressions. No patch expected from the Rust side right now, so the more explicit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using Rust 1.86 and one compile error showed up for ssstar.
I think this is a regression in the compiler, so I submitted a report rust-lang/rust#139542
But eventually when
ByteStrstabilizes this problem may come back. So usingas_str()should help with this.