Skip to content

Fix rust-analyzer "Go to Definition" inside #[builder] functions #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Veetaha merged 1 commit into from
Jun 10, 2026
+9 −5
Merged

Fix rust-analyzer "Go to Definition" inside #[builder] functions #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions bon-macros/src/builder/builder_gen/start_fn.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,7 @@ impl super::BuilderGenCtx {
format_ident!("elidable_lifetime_names")
};

// Construct using a span which links to our original implementation.
// This ensures rustdoc doesn't just link every method to the macro
// callsite.
syn::parse_quote_spanned! {self.start_fn.span=>
let mut start_fn: syn::ItemFn = syn::parse_quote! {
#(#docs)*
#[inline(always)]
#[allow(
Expand Down Expand Up @@ -143,6 +140,13 @@ impl super::BuilderGenCtx {
__unsafe_private_named: #named_members_field_init,
}
}
}
};

let span = self.start_fn.span;

start_fn.sig.fn_token = syn::Token![fn](span);
start_fn.block.brace_token = syn::token::Brace(span);

start_fn
}
}
Loading