add categories to data_stream #1065
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
|
Contributor
Author
|
@jsoriano can I get review for this PR? thanks |
Member
|
Commented in the internal issue about some open questions related to the implications of this change, please wait before going on with it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Over the past few months we have been discussed discrepancies between in telemetry due to non sufficient granularity for categorisation. We declare categories on integration level, but every data_stream should have it’s own category for correct telemetry
see more in https://github.com/elastic/security-team/issues/15583
Why is it important?
There have been couple of proposals on how to achieve needed level of granularity. The easiest and clearer way is to put category where it belongs - to its data_stream.
This change is backward compatible because new field is optional. It means we shouldn’t now redefine all the data_streams, but only those with mismatch between integration’s categories and particular data_stream
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues