Conversation
v0.27.0 is marked as a breaking release. The breaking change (cel-expr/cel-go@c66b3130b) removes standard type names (int, string, bool, etc.) from the environment's variable declarations. Before this change, declaring a user variable with one of those names caused an "overlapping identifier" error; now user variables can shadow type names. Type resolution is unaffected because the checker falls through to the type provider. We do not declare any user variables with standard type names, so this has no impact on mito. [git-generate] go get google.golang.org/genproto/googleapis/rpc@v0.0.0-20260319201613-d00831a3d3e7 go get github.com/google/cel-go@v0.27.0 go mod tidy go run github.com/uber-go/gopatch@latest . << PATCH @@ @@ - ast, iss = cel.NewStaticOptimizer(folder).Optimize(env, ast) + opt, err := cel.NewStaticOptimizer(folder) + if err != nil { + return nil, nil, nil, fmt.Errorf("failed to make new static optimizer: %v", err) + } + ast, iss = opt.Optimize(env, ast) @@ @@ - return types.NewErr(err.Error()) + return types.NewErr("%v", err) @@ var x identifier @@ - return types.ValOrErr(x, "no such overload for "+name) + return types.ValOrErr(x, "no such overload for %s", name) PATCH
andrewkroh
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit message for details.