Clarify titles and descriptions of various packages of same technology#19526
Clarify titles and descriptions of various packages of same technology#19526MichelLosier wants to merge 3 commits into
Conversation
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
access |
2747.25 | 2109.7 | -637.55 (-23.21%) | 💔 |
error |
4405.29 | 3610.11 | -795.18 (-18.05%) | 💔 |
Package apache_tomcat 👍(4) 💚(1) 💔(4)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
access |
2409.64 | 1524.39 | -885.25 (-36.74%) | 💔 |
catalina |
14705.88 | 9803.92 | -4901.96 (-33.33%) | 💔 |
localhost |
15384.62 | 12345.68 | -3038.94 (-19.75%) | 💔 |
session |
27027.03 | 16129.03 | -10898 (-40.32%) | 💔 |
Package kafka 👍(0) 💚(0) 💔(1)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
log |
9615.38 | 8130.08 | -1485.3 (-15.45%) | 💔 |
Package mysql 👍(1) 💚(1) 💔(1)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
slowlog |
26315.79 | 19607.84 | -6707.95 (-25.49%) | 💔 |
Package mysql_enterprise 👍(0) 💚(0) 💔(1)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
audit |
3703.7 | 2092.05 | -1611.65 (-43.51%) | 💔 |
To see the full report comment with /test benchmark fullreport
jmikell821
left a comment
There was a problem hiding this comment.
Reviewed all the title/description updates. Everything from my end LGTM!
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
|
Pinging @elastic/ecosystem (Team:Ecosystem) |
There was a problem hiding this comment.
READMES and any other doc that is referencing the title and description should be align with changes. i think the best will be asking claude to go through all the updated integrations and make sure _dev/build/docs/README.md is aligned with the changes and then regenerate docs/README.md with elastic-package build command (this one is generated from the template one)
i was trying to look if the title or description was referenced as a template variable but it appears they are hardcoded.... also keep in mind i see some packages not having the template (_dev/build/docs) but directly the docs/README.md
A quick way to check this is seen correctly is by using the elastic-package tool. When running elastic-package stack up within the root of the integrations repository, the local registry used on the stack includes the local builds of the packages... so for instance, you could elastic-package foearch -- build (this builds all the packages) and then run the stack. When you go to the local kibana you should be able to see the tiles renamed and the package documentation updated. let me know if you have any doubt
EDIT: also, could we wrap up a small skill/rule/X where the style on titles and descriptions are stablished so future itegrations follow the same aproach. i am thinking on referencing an AI agent to review the integration and check for this (as for example we use Vale linting for written style)
|
✅ All changelog entries have the correct PR link. |
|
Thanks for the catch there @teresaromero! I've updated the Readmes in 62e33b7 |
💚 Build Succeeded
History
|
Proposed commit message
Updates the titles and descriptions of various packages that observe the same technology to clarify their distinction
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots