Skip to content

osquery_manager: update ECS mapping#16650

Merged
mmahacek merged 11 commits intomainfrom
mm/osquery_manager-mappings
Apr 28, 2026
Merged

osquery_manager: update ECS mapping#16650
mmahacek merged 11 commits intomainfrom
mm/osquery_manager-mappings

Conversation

@mmahacek
Copy link
Copy Markdown
Contributor

A number of ECS fields are not defined within the integration field mapping, which is causing them to map as object instead of the expected nested type. These fields are:

dll.pe.sections
file.macho.sections
file.pe.sections
process.parent.macho.sections
process.parent.pe.sections
threat.enrichments.indicator.file.pe.sections
threat.indicator.file.pe.sections

Additionally, the integration defines an error field as text, however this conflicts with the ECS error field that is expected to be an object.

Proposed commit message

osquery_manager: update ECS mapping and rename error to error.message

Please explain:

  • WHAT: patterns used, algorithms implemented, design architecture, message processing, etc.
  • WHY: the rationale/motivation for the changes

This text will be pasted into the squash dialog when the change is committed and will be
a long term historical record of the change to help future contributors understand the
change, please help them by making it clear and comprehensive, they may be you.

If the commit title is adequate to describe both of these things, The text here may be omitted
or replaced with "See title". The title of the PR will be used as the commit message title when
the merge is made and the "See title" marker will be removed if present.

The text here and the PR title will be subject to the PR review process.
-->
Update ECS mapping for the osquery_manager.results datastream.
Update osquery_manager.action_responses ingest pipeline to rename error to error.message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

There are no special tests to run outside of elastic-package test

Related issues

Screenshots

Rename error to error.message
@mmahacek mmahacek self-assigned this Dec 19, 2025
@mmahacek mmahacek added bug Something isn't working, use only for issues enhancement New feature or request Integration:osquery_manager Osquery Manager labels Dec 19, 2025
@mmahacek mmahacek marked this pull request as ready for review January 13, 2026 16:53
@mmahacek mmahacek requested a review from a team as a code owner January 13, 2026 16:53
@mmahacek mmahacek requested review from parkiino and tomsonpl January 13, 2026 16:53
@mmahacek
Copy link
Copy Markdown
Contributor Author

Marking as ready for review. Buildkite fails, however it passes tests locally.

@mmahacek mmahacek enabled auto-merge (squash) January 13, 2026 16:54
@andrewkroh andrewkroh added the Team:Defend Workflows Security team for Endpoint and OSQuery workflows [elastic/security-defend-workflows] label Jan 13, 2026
@mmahacek
Copy link
Copy Markdown
Contributor Author

@elastic/security-defend-workflows Can I get a review on this and check why buildkite fails when tests pass locally? The plan is to also backport these changes to 8.19, though I don't know the process for that. Thanks in advance!

@tomsonpl tomsonpl requested review from marc-gr and removed request for parkiino January 21, 2026 08:28
Copy link
Copy Markdown
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for taking care of these, really appreciated ❤️
I am not sure what the process of backporting is either, sorry can't help.
But I left a comment regarding the compilation error, please see if that makes any sense.

@mmahacek
Copy link
Copy Markdown
Contributor Author

@tomsonpl I fixed the buildkite error with your suggestion. Can you check and re-review this PR? Thanks!

@mmahacek
Copy link
Copy Markdown
Contributor Author

@marc-gr would you be able to review this PR? This is related to an issue found during SDH.

@mmahacek
Copy link
Copy Markdown
Contributor Author

@elastic/security-defend-workflows Is someone available to review this PR? This is a fix for an issue raised via SDH. Thanks in advance!

@mmahacek mmahacek requested review from a team and removed request for marc-gr March 19, 2026 18:24
@mmahacek mmahacek requested review from joeypoon and paul-tavares and removed request for a team March 19, 2026 18:24
@paul-tavares paul-tavares removed their request for review March 24, 2026 14:15
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

cc @mmahacek

@marc-gr marc-gr requested review from tomsonpl and removed request for joeypoon April 28, 2026 11:46
Copy link
Copy Markdown
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@mmahacek mmahacek merged commit 1510358 into main Apr 28, 2026
9 checks passed
@mmahacek mmahacek deleted the mm/osquery_manager-mappings branch April 28, 2026 12:08
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package osquery_manager - 1.28.1 containing this change is available at https://epr.elastic.co/package/osquery_manager/1.28.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues enhancement New feature or request Integration:osquery_manager Osquery Manager Team:Defend Workflows Security team for Endpoint and OSQuery workflows [elastic/security-defend-workflows]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[osquery_manager]: Update *.sections field mappings to match ECS

5 participants