[EuiWindowEvent] Refactor class component to functional component#9536
Open
barlima wants to merge 1 commit intoelastic:mainfrom
Open
[EuiWindowEvent] Refactor class component to functional component#9536barlima wants to merge 1 commit intoelastic:mainfrom
barlima wants to merge 1 commit intoelastic:mainfrom
Conversation
|
👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EuiWindowEventfrom a class component to a function component.EuiWindowEventas a functional equivalent usinguseEffectwith[event, handler]dependencies to match the class component's update logic (only re-registers the listener wheneventorhandlerchange).API Changes
No API changes
Screenshots
No visual changes
Impact Assessment
[ ] 🔴 Breaking changes[ ] 💅 Visual changes[ ] 🔧 Hard to integrateImpact level: 🟢 None
Release Readiness
Documentation:Figma:Migration guide:Adoption planQA instructions for reviewer
Checklist before marking Ready for Review
Edge/Firefox, keyboard-only,screen readerQA: Tested in CodeSandbox and KibanaQA: Tested docs changesTests: Added/updated Jest, Cypress, and VRTChangelog: Added changelog entryBreaking changes: Addedbreaking changelabel (if applicable)Reviewer checklist