[RFC] Stage 1: Introducing new field in ECS Rule fields#2386
[RFC] Stage 1: Introducing new field in ECS Rule fields#2386smriti0321 wants to merge 16 commits intoelastic:mainfrom
Conversation
Updating the temaplate for RFC Stage 0 for adding 2 new rule fields: rule.tags and rule.remediation
Incorporating review comments.
… number in series.
|
Hi! We just realized that we haven't looked into this PR in a while. We're We're labeling this PR as Thank you for your contribution! |
|
Hi! We just realized that we haven't looked into this PR in a while. We're We're labeling this PR as Thank you for your contribution! |
mjwolf
left a comment
There was a problem hiding this comment.
@smriti0321, could you also update https://github.com/elastic/ecs/blob/main/rfcs/text/0046-additional-rule-field.md to add some examples of usage, source data and the other criteria from here: https://elastic.github.io/ecs/stages.html
| fields: | ||
| - name: remediation | ||
| level: extended | ||
| type: wildcard |
There was a problem hiding this comment.
Would remediations usually be human-readable? In that case, using text type could be better than wildcard: https://www.elastic.co/guide/en/elasticsearch/reference/current/keyword.html#wildcard-field-type
There was a problem hiding this comment.
@mjwolf I have created a PR (#2448) for the suggested changes in https://github.com/elastic/ecs/blob/main/rfcs/text/0046-additional-rule-field.md. Please let me know if thats the right way.
As per comment (#2386 (review)) on Stage 1 of this RFC. Adding the usage, source data and scope of impact
|
Hi! We just realized that we haven't looked into this PR in a while. We're We're labeling this PR as Thank you for your contribution! |
|
This PR has been automatically closed due to inactivity. If you'd like to Thank you for your contribution! |
make test?makeand committed those changes?