RFC Stage 1: TSDB Dimensions#2217
Conversation
|
From Stage 0 to Stage 1, fields chosen as dimension fields were re-assessed here. Stage 1 thus has Three additions : in comparison with what is initially estimated in Stage 0. No similar changes are expected in near future. |
|
Related Stage 0 RFC |
ruflin
left a comment
There was a problem hiding this comment.
Overall LGTM. @lalit-satapathy and team, please dive into the details of each field.
One general comment: There is currently a merger ongoing with semconv and in otel everything is a dimension which currently does not work with Elasticsearch. Before a lengthy discussion pops up around should this be in ECS or not, I would like to side step this and keep this PR moving.
There needs to be a more general discussion to have how we store additional info specific to Elasticsearch related to ECS in the future merged schema (or besides it). Lets do it in a separate issue.
|
Reasoning behind inclusions of fields as dimensions and changes from Stage 0 to Stage 1 are mentioned below
|
|
@agithomas , @lalit-satapathy Has a separate issue been created for this around the merged schema? Is there value in keeping this issue open anymore? |
|
This PR is stale because it has been open for 60 days with no activity. |
|
This PR has been automatically closed due to inactivity. If you'd like to Thank you for your contribution! |
Have you signed the contributor license agreement? yes
Have you followed the contributor guidelines? yes
For proposing substantial changes or additions to the schema, have you reviewed the [RFC process] (https://github.com/elastic/ecs/blob/main/rfcs/README.md)? yes
If submitting code/script changes, have you verified all tests pass locally using make test?
If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?
Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
Have you added an entry to the CHANGELOG.next.md?