-
Notifications
You must be signed in to change notification settings - Fork 195
Enhance Fleet & Agent docs with comprehensive deployment guides #4346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Vale Linting ResultsSummary: 11 suggestions found 💡 Suggestions (11)
|
|
Hi @karenzone - sorry to call you out like this, but would you have some time to review this? The idea behind the PR is to create new pages that consolidate the (so far a bit scattered) info on Fleet/Agent deployments. The guides are split into sections by connection type. I decided to keep the platform-specific guides as separate pages and added links to the new pages where I thought it was relevant. I was mostly working based on the existing docs and configuration examples, so in reality I didn't write a lot of truly "new" content, but still I feel like someone with Agent/Fleet experience should take a look at this - that's why I'm asking you 🙂 |
@alexandra5000, I am OOO tomorrow, and returning on Thursday. I can review then. |
karenzone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexandra5000, made a first pass to get a sense of what's going on here. I will make another pass tomorrow with some suggestions.
I understand why you placed these new topics where you did in the TOC. As they're so similar, I'm wondering if they should be closer together to reinforce that these two tasks are quite similar. I'll kick that around a bit.
|
@karenzone the problem I had with this is that the only logical place to put them together would be at the very top level (same as I'm looking forward to hearing your thoughts on this! |
|
Hey @alexandra5000 — we merged the PR adding When you address the merge conflicts, please take into account the changes in #3238 as they have already been reviewed and approved by @karenzone and @bmorelli25. |
|
The book has outgrown its initial IA, and is tricky to add to. This PR could benefit from more pre-IA analysis with regard to the approach and location. Fleet Server is an Elastic Agent with additional capabilities enabled, and the settings are similar for both. Maintaining the same content in two different places sets us up for content diverging. We have some capabilities for single sourcing content, and that approach is worth considering. AI tends to be wordier than needed, and leans toward admonitions instead of normal content. Worth a look in context of this PR. |
|
@vishaangelova Conflicts resolved, I paid attention to keep what you had in your PR 🫡 @karenzone Right, good points all. I made some changes to the content itself and the placement. I've also added some snippets to hopefully make it easier to maintain. I'm still thinking about other good ways to single-source the content. |
| applies_to: | ||
| stack: ga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s remove this as the applies_to in the metadata for this file is already added on lines 7-9 (current line numbering)
| applies_to: | |
| stack: ga |
| sub: | ||
| component_name: "Elastic Agent" | ||
| component_ref: "{{agent}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think you need to define the sub here, it’s not a local substitution, it’s already in the docs-content’s docset.yml: https://github.com/elastic/docs-content/blob/main/docset.yml#L134
So it would be enough to just use {{agent}} as a sub across all of the docs.
| applies_to: | ||
| stack: ga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regardless of how the agent is deployed on the host, you can use that agent with a Serverless project… With my current understanding of using applies_to in the frontmatter, I think here it should also include Serverless.
| applies_to: | |
| stack: ga | |
| applies_to: | |
| stack: ga | |
| serverless: ga |
| mapped_pages: | ||
| - https://www.elastic.co/guide/en/fleet/current/deploy-elastic-agent.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page did not exist in previous doc versions, so you don’t need to add mapped_pages.
| mapped_pages: | |
| - https://www.elastic.co/guide/en/fleet/current/deploy-elastic-agent.html |
| sub: | ||
| component_name: "Fleet Server" | ||
| component_ref: "{{fleet-server}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly to my comment for the other doc, this sub is already defined in docs-content’s docset.yml: https://github.com/elastic/docs-content/blob/main/docset.yml#L137
You can just use {{fleet-server}} as a sub across all of the docs.
| mapped_pages: | ||
| - https://www.elastic.co/guide/en/fleet/current/deploy-fleet-server.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly to my previous comment:
| mapped_pages: | |
| - https://www.elastic.co/guide/en/fleet/current/deploy-fleet-server.html |
| applies_to: | ||
| stack: ga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably say serverlesss: unavailable because self-managed Fleet Server is not available on Serverless.
| applies_to: | |
| stack: ga | |
| applies_to: | |
| stack: ga | |
| serverless: unavailable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t agree with the deletions in this file. Let’s discuss this.
| * When using the **Advanced** option, it’s recommended to generate a unique service token for each {{fleet-server}}. For other ways to generate service tokens, refer to [`elasticsearch-service-tokens`](elasticsearch://reference/elasticsearch/command-line-tools/service-tokens-command.md). | ||
| * If you’ve configured a non-default port for {{fleet-server}} in the {{fleet-server}} integration, you need to include the `--fleet-server-host` and `--fleet-server-port` options in the `elastic-agent install` command. Refer to the [install command documentation](/reference/fleet/agent-command-reference.md#elastic-agent-install-command) for details. | ||
| * When using the **Advanced** option, it's recommended to generate a unique service token for each {{fleet-server}}. For other ways to generate service tokens, refer to [`elasticsearch-service-tokens`](elasticsearch://reference/elasticsearch/command-line-tools/service-tokens-command.md). | ||
| * If you've configured a non-default port for {{fleet-server}} in the {{fleet-server}} integration, you need to include the `--fleet-server-host` and `--fleet-server-port` options in the `elastic-agent install` command. For detailed information about all available configuration flags and environment variables, refer to [How to deploy Fleet Server](/reference/fleet/deploy-fleet-server.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with the deletion of the link to the elastic-agent install command reference. I think this should still point to the agent command reference doc, and not to the “how-to” doc as the command reference doc should be the ultimate go-to for all available flags.
|
|
||
| * Before running the `install` command, make sure you replace the values in angle brackets. | ||
| * The URL specified by `--url` must match the DNS name used to generate the certificate specified by `--fleet-server-cert`. | ||
| * For comprehensive configuration details, including all available flags and environment variables, refer to [How to deploy Fleet Server](/reference/fleet/deploy-fleet-server.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line doesn’t fit the list items or the purpose of the list. This info is also added on line 119… (parent list item)
Summary
This PR adds detailed guides for deploying Fleet Server and Elastic Agent, including configuration flags, environment variables, and mutual TLS (mTLS) setup. The new documents provide organized information for various deployment models, ensuring users have access to best practices and prerequisites for successful implementation. Additionally, tips for configuration management and security considerations are included to aid users in effectively managing their deployments.
Closes #4146
Generative AI disclosure
Tool(s) and model(s) used: Claude Sonnet 4.5 via Cursor