Skip to content

[FR] Minor Typo Fixes#5784

Merged
Mikaayenson merged 5 commits intomainfrom
grammar_updates
Mar 6, 2026
Merged

[FR] Minor Typo Fixes#5784
Mikaayenson merged 5 commits intomainfrom
grammar_updates

Conversation

@eric-forte-elastic
Copy link
Copy Markdown
Contributor

@eric-forte-elastic eric-forte-elastic commented Feb 25, 2026

Pull Request

Issue link(s):

Related to https://github.com/elastic/ia-trade-team/issues/830

Summary - What I changed

Minor update to correct common typo/spelling or grammar mistakes.

How To Test

Unit tests.

Checklist

  • Added a label for the type of pr: bug, enhancement, schema, maintenance, Rule: New, Rule: Deprecation, Rule: Tuning, Hunt: New, or Hunt: Tuning so guidelines can be generated
  • Added the meta:rapid-merge label if planning to merge within 24 hours
  • Secret and sensitive material has been managed correctly
  • Automated testing was updated or added to match the most common scenarios
  • Documentation and comments were added for features that require explanation

Contributor checklist

@tradebot-elastic
Copy link
Copy Markdown

tradebot-elastic commented Feb 25, 2026

⛔️ Test failed

Results
  • ❌ M365 SharePoint Malware File Detected (kuery)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Potential Port Monitor or Print Processor Registration Abuse (eql)
    • stack_validation_failed: no_alerts - 0 alerts
  • ❌ M365 OneDrive Malware File Upload (kuery)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@eric-forte-elastic eric-forte-elastic added documentation Improvements or additions to documentation Rule: Tuning tweaking or tuning an existing rule patch labels Feb 25, 2026
@eric-forte-elastic eric-forte-elastic self-assigned this Feb 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.

@tradebot-elastic
Copy link
Copy Markdown

tradebot-elastic commented Feb 25, 2026

⛔️ Test failed

Results
  • ❌ M365 SharePoint Malware File Detected (kuery)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Potential Port Monitor or Print Processor Registration Abuse (eql)
    • stack_validation_failed: no_alerts - 0 alerts
  • ❌ M365 OneDrive Malware File Upload (kuery)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 25, 2026

🔍 Preview links for changed docs

@tradebot-elastic
Copy link
Copy Markdown

tradebot-elastic commented Feb 25, 2026

⛔️ Test failed

Results
  • ❌ M365 SharePoint Malware File Detected (kuery)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Potential Port Monitor or Print Processor Registration Abuse (eql)
    • stack_validation_failed: no_alerts - 0 alerts
  • ❌ M365 OneDrive Malware File Upload (kuery)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@tradebot-elastic
Copy link
Copy Markdown

tradebot-elastic commented Feb 25, 2026

⛔️ Test failed

Results
  • ❌ M365 SharePoint Malware File Detected (kuery)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Potential Port Monitor or Print Processor Registration Abuse (eql)
    • stack_validation_failed: no_alerts - 0 alerts
  • ❌ M365 OneDrive Malware File Upload (kuery)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@eric-forte-elastic eric-forte-elastic changed the title WIP - Minor Typo Fixes [FR] Minor Typo Fixes Feb 25, 2026
@eric-forte-elastic eric-forte-elastic marked this pull request as ready for review February 25, 2026 22:23
Copy link
Copy Markdown
Contributor

@Mikaayenson Mikaayenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Mikaayenson Mikaayenson merged commit 94c73e3 into main Mar 6, 2026
9 checks passed
@Mikaayenson Mikaayenson deleted the grammar_updates branch March 6, 2026 22:12
@tradebot-elastic
Copy link
Copy Markdown

tradebot-elastic commented Mar 6, 2026

⛔️ Test failed

Results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport: auto documentation Improvements or additions to documentation Domain: Cloud Domain: Endpoint Hunting Integration: Microsoft 365 OS: Windows windows related rules patch Rule: Tuning tweaking or tuning an existing rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants