feat: reenable buildvcs

[kruskall]

Proposed commit message

buildvcs was disabled a few years ago because of compile errors due to missing git objects. This has been resolved so we should reenable it

See golang/go#65339

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
• I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

Author's Checklist

• [ ]

How to test this PR locally

Related issues

Alternative fix for #49360

Use cases

Screenshots

Logs

[github-actions]

🤖 GitHub comments

Just comment with:

• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kruskall? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
• backport-active-all is the label that automatically backports to all active branches.
• backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
• backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f76cb762-b2c4-498f-b90d-af985fd90513

📥 Commits

Reviewing files that changed from the base of the PR and between 8ae8d12 and aafc30e.

📒 Files selected for processing (1)

• dev-tools/mage/crossbuild.go

---

📝 Walkthrough

Walkthrough

A modification was made to the containerized build environment configuration in GolangCrossBuilder. The -buildvcs=false flag was removed from the GOFLAGS environment variable within the docker run invocation for the Build path. This change alters the VCS check behavior during module resolution, allowing VCS checks to proceed based on Go's default settings rather than being explicitly disabled. The modification affects only build environment configuration with no changes to function signatures, interfaces, or exported types.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

• 🛠️ Update Documentation: Commit on current branch
• 🛠️ Update Documentation: Create PR

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[elasticmachine]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

[mauri870]

LGTM, confirmed binaries have vcs information now.

[github-actions]

@Mergifyio backport 8.19 9.2 9.3

[mergify]

backport 8.19 9.2 9.3

✅ Backports have been created

Details

• #49410 [8.19](backport #49365) feat: reenable buildvcs has been created for branch 8.19
• #49411 [9.2](backport #49365) feat: reenable buildvcs has been created for branch 9.2
• #49412 [9.3](backport #49365) feat: reenable buildvcs has been created for branch 9.3