feat: replace archived yaml dependency#49339
Conversation
go-yaml/yaml has been archived and the maintained fork is at go.yaml.in/yaml Since some of our dependencies already migrated we're linking two yaml libraries in the binary. Replace usage of the archived library to start removing it
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughImports for YAML were migrated across the repository from Suggested labels
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@x-pack/osquerybeat/ext/osquery-extension/cmd/gentables/go.mod`:
- Line 8: Update the golang.org/x/text dependency in go.mod from the pinned
older pseudo-version (golang.org/x/text v0.3.1-0.20180807135948-17ff2d5776d2) to
a patched release (v0.3.8 or later) to address CVE-2020-14040 and
CVE-2022-32149; after changing the version, regenerate module metadata (e.g.,
run go get golang.org/x/text@v0.3.8 and go mod tidy) so the new version is
recorded and vendor/sums are updated.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cc0aa794-bace-4ecc-94e5-e77c656b8f08
⛔ Files ignored due to path filters (1)
x-pack/osquerybeat/ext/osquery-extension/cmd/gentables/go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
x-pack/osquerybeat/ext/osquery-extension/cmd/gentables/go.mod
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
Pinging @elastic/integrations (Team:Integrations) |
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
|
/test |
belimawr
left a comment
There was a problem hiding this comment.
LGTM, but it would be good to update golang.org/x/text as well.
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Done! |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Proposed commit message
go-yaml/yaml has been archived and the maintained fork is at go.yaml.in/yaml
Since some of our dependencies already migrated we're linking two yaml libraries in the binary.
Replace usage of the archived library to start removing it
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs