Fix Liquity Stability Pool to work with changing LUSD/ETH balances#87
Draft
davekay100 wants to merge 1 commit intokhuo/add-lusd-amofrom
Draft
Fix Liquity Stability Pool to work with changing LUSD/ETH balances#87davekay100 wants to merge 1 commit intokhuo/add-lusd-amofrom
davekay100 wants to merge 1 commit intokhuo/add-lusd-amofrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary Goals of PR
The current version of the module doesn't work since the underlying LUSD and ETH are always changing. We need to keep track of this.
I found a protocol that has already done it, but the code needs some modifying, I am in the middle of modifying it.
In draft until it's ready with tests.
Also, need to talk about making it a single file, or split it into an AMO and a module file. in this scenario I'm thinking 1 file, but need to talk it out