Skip to content

Switch to explicit nullable types (Deprecation in PHP 8.4) #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
burki wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Switch to explicit nullable types (Deprecation in PHP 8.4) #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd4ff5c
maintenance : deprecation symfony
encreinformatique Nov 14, 2024
57060df
Merge pull request #1 from encreinformatique/encreinformatique-patch-1
encreinformatique Nov 14, 2024
4889cee
Switch to explicit nullable types (Deprecation in PHP 8.4)
burki Mar 17, 2025
d5dd22a
Merge pull request #1 from encreinformatique/master
burki Dec 1, 2025
0cf3dfa
Add void return types to address Symfony deprecations
burki Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Command/FeedDumpCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class FeedDumpCommand extends Command
*/
private $feedDumpService;

public function __construct(RouterInterface $router, FeedDumpService $feedDumpService = null)
public function __construct(RouterInterface $router, ?FeedDumpService $feedDumpService = null)
{
$this->router = $router;
$this->feedDumpService = $feedDumpService;
Expand All @@ -50,7 +50,7 @@ public function __construct(RouterInterface $router, FeedDumpService $feedDumpSe
/**
* {@inheritdoc}
*/
protected function configure()
protected function configure(): void
{
$this
->setDescription('Generate (dump) a feed in an XML file')
Expand Down
2 changes: 1 addition & 1 deletion DependencyInjection/Compiler/FeedDumpServicePass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class FeedDumpServicePass implements CompilerPassInterface
/**
* {@inheritdoc}
*/
public function process(ContainerBuilder $container)
public function process(ContainerBuilder $container): void
{
if (!$container->hasAlias('doctrine.orm.entity_manager')) {
$container->removeDefinition(FeedDumpService::class);
Expand Down
2 changes: 1 addition & 1 deletion DependencyInjection/Compiler/FeedFormatterPass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class FeedFormatterPass implements CompilerPassInterface
/**
* {@inheritdoc}
*/
public function process(ContainerBuilder $container)
public function process(ContainerBuilder $container): void
{
$formatters = [];

Expand Down
4 changes: 2 additions & 2 deletions DependencyInjection/EkoFeedExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class EkoFeedExtension extends Extension
* @param array $configs An array of configuration settings
* @param ContainerBuilder $container A container builder instance
*/
public function load(array $configs, ContainerBuilder $container)
public function load(array $configs, ContainerBuilder $container): void
{
$config = $this->processConfiguration(new Configuration(), $configs);

Expand All @@ -55,7 +55,7 @@ public function load(array $configs, ContainerBuilder $container)
*
* @throws \RuntimeException
*/
protected function configureHydrator(array $config, ContainerBuilder $container)
protected function configureHydrator(array $config, ContainerBuilder $container): void
{
if (!$container->hasDefinition($config['hydrator'])) {
throw new \RuntimeException(sprintf('Unable to load hydrator service "%s"', $config['hydrator']));
Expand Down
2 changes: 1 addition & 1 deletion Formatter/Formatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ protected function formatWithOptions(ItemFieldInterface $field, ItemInterface $i
* @param ItemFieldInterface $field A feed field instance
* @param ItemInterface|null $item A feed item instance
*/
protected function addAttributes(\DOMElement $element, ItemFieldInterface $field, ItemInterface $item = null)
protected function addAttributes(\DOMElement $element, ItemFieldInterface $field, ?ItemInterface $item = null)
{
foreach ($field->getAttributes() as $key => $value) {
if ($item) {
Expand Down