fix: use golang.org/x/net/html to parse HTML instead of regular expressions#38
Open
cgrindel wants to merge 18 commits intoekalinin:masterfrom
Open
fix: use golang.org/x/net/html to parse HTML instead of regular expressions#38cgrindel wants to merge 18 commits intoekalinin:masterfrom
golang.org/x/net/html to parse HTML instead of regular expressions#38cgrindel wants to merge 18 commits intoekalinin:masterfrom
Conversation
cgrindel
force-pushed
the
upgrade_to_go_1_19_1
branch
from
b75d2a6 to
563f232
Compare
Author
|
@ekalinin I must have had an old fork. I have rebased from master. This PR should be ready for review. |
Author
|
@ekalinin Gentle ping for a review. Thanks! |
Author
|
@ekalinin I just wanted to check in to see if you could look at this pull request. Using the HTML package to parse the HTML should avoid any future failures due to subtle changes in the HTML produced by GitHub. I look forward to your feedback. |
Author
|
@ekalinin Any thoughts on this PR? |
cgrindel
added a commit
to cgrindel/bazel-starlib
that referenced
this pull request
Aug 30, 2023
…342) - Fork https://github.com/ekalinin/github-markdown-toc.go with [HTML parsing changes](ekalinin/github-markdown-toc.go#38). - Remove references to the original repo. - Removed `cmd/go_deps` as it is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to cgrindel/bazel-starlib#160
The HTML being returned by GitHub seems to have changed slightly. The regular expression was not working.
htmlpackage to parse the HTML generated from the markdown.io/ioutil.