This repository was archived by the owner on Jul 3, 2021. It is now read-only.
Added move types#33
Closed
Allui wants to merge 1 commit intoejeinc:masterfrom
mintrocket:feature/moveModes
Closed
Conversation
Collaborator
|
Hi @Allui, Thanks for your PR! We are also considering features like movement mode for In your code, you defined How about implementing this feature as separated variables like this? (#34) // PanoramaView.swift
public var isDeviceMotionEnabled: Bool { get set }
public var isPanGestureEnabled: Bool { get set } |
Author
|
Hi @junpluse, This (#34) solution is better, but how to reset camera position to zero, when changing movement mode on the fly? For this i made: // OrientationNode.swift
public func fullyResetRotation() {
userRotationNode.transform = SCNMatrix4Identity
referenceRotationNode.transform = SCNMatrix4Identity
deviceOrientationNode.transform = SCNMatrix4Identity
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added feature:
Three movement mode of panorama
touch
motion
all (touch and motion)
Example "MonoImage" changed for demonstrate new feature.
(I accidentally broke the old pull request while doing the rebase, so I made a new one. D:)