Pattern: use PolyRegex for receiver and return of pattern and toString#132
Open
Pattern: use PolyRegex for receiver and return of pattern and toString#132
Pattern: use PolyRegex for receiver and return of pattern and toString#132Conversation
There was a problem hiding this comment.
Pull request overview
Updates java.util.regex.Pattern’s API annotations to better express Regex Checker qualifier polymorphism, so callers can preserve regex-qualification through pattern() and toString() based on the receiver’s qualifier.
Changes:
- Annotate
Pattern.pattern()with@PolyRegexon both receiver and return type. - Annotate
Pattern.toString()with@PolyRegexon both receiver and return type (while preserving@GuardSatisfied).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1132,7 +1132,7 @@ public String pattern() { | |||
| * @since 1.5 | |||
| */ | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with eisop/checker-framework#1590