Mismatched `checker-qual` artifact example by ShahriarAhnaf · Pull Request #1318 · eisop/checker-framework

ShahriarAhnaf · 2025-07-05T19:06:00Z

#1107 creating an example to recreate the crash. Copied from ErrorProne example. Using for test validation of the subpackage graceful handling in the case of a mismatch.

Fixes #1243

… Later

ShahriarAhnaf · 2025-07-05T19:10:48Z

This is for #1243 subtask.

wmdietl

Thanks for starting this!
Please add #1243 to the changelog.

To fix the misc failure, follow the steps from the error message:

+ git diff --exit-code docs/manual/contributors.tex
diff --git a/docs/manual/contributors.tex b/docs/manual/contributors.tex
index 8852dac7f..579eabdc2 100644
--- a/docs/manual/contributors.tex
+++ b/docs/manual/contributors.tex
@@ -1,6 +1,7 @@
 Abraham Lin,
 Adian Qian,
 Aditya Singh,
+Ahnaf Shahriar,
 Akash Srivastava,
 Alex Cook,
 Alex Liu,
+ set +x
docs/manual/contributors.tex is not up to date.
If the above suggestion is appropriate, run: make -C docs/manual contributors.tex
If the suggestion contains a username rather than a human name, then do all the following:
  * Update your git configuration by running:  git config --global user.name "YOURFULLNAME"
  * Add your name to your GitHub account profile at https://github.com/settings/profile
  * Make a pull request to add your GitHub ID to
    https://github.com/eisop-plume-lib/git-scripts/blob/master/git-authors.sed
    and remake contributors.tex after that pull request is merged.

.gitignore

docs/examples/Makefile

docs/examples/Wrong-Checker-Qual/build.gradle

Co-authored-by: Werner Dietl <wdietl@gmail.com>

…ualifiers instead of dependencies

wmdietl

Thanks for the extra test!

wmdietl · 2025-09-01T19:13:31Z

.gitignore

-docs/examples/errorprone/.gradle/
 docs/examples/errorprone/Out.txt
-docs/examples/nullaway/.gradle/
+docs/examples/Wrong-Checker-Qual/Out.txt


Suggested change

docs/examples/Wrong-Checker-Qual/Out.txt

docs/examples/mismatched-checker-qual/Out.txt

wmdietl · 2025-09-01T19:13:49Z

docs/examples/Makefile

 	$(MAKE) -C BazelExample clean
 	$(MAKE) -C nullaway clean
 	$(MAKE) -C jspecify clean
+	$(MAKE) -C mismatched-checker-qual clean


Suggested change

$(MAKE) -C mismatched-checker-qual clean

$(MAKE) -C mismatched-checker-qual clean

wmdietl · 2025-09-01T19:14:15Z

docs/examples/mismatched-checker-qual/build.gradle

+        'org.checkerframework.checker.nullness.NullnessChecker',
+    ]
+    extraJavacArgs = ['-Aversion']
+}


Suggested change

}

}

wmdietl · 2025-09-01T19:14:44Z

docs/examples/mismatched-checker-qual/Makefile

+
+.PHONY: all clean
+
+ifeq ($(shell test $(JAVA_VER) -lt 17; echo $$?),0)


This test isn't using errorprone, so this can be simplified.

wmdietl · 2025-09-01T19:15:19Z

docs/examples/mismatched-checker-qual/Makefile

+else
+all:
+	- ../../../gradlew build > Out.txt 2>&1
+	# Check for crash due to mismatched Checker Qualifiers


Add a TODO, here or somewhere else, that explains that we would want more graceful behavior.

wmdietl · 2025-09-01T19:43:13Z

docs/examples/mismatched-checker-qual/build.gradle

+
+ext {
+    versions = [
+        eisopVersion: '3.49.3-eisop1',


Suggested change

eisopVersion: '3.49.3-eisop1',

eisopVersion: '3.49.3-eisop1',

typetoolsVersion: '3.49.1',

wmdietl · 2025-09-01T19:43:47Z

docs/examples/mismatched-checker-qual/build.gradle

+    compileOnly "org.checkerframework:checker-qual:3.49.1"
+    testCompileOnly "org.checkerframework:checker-qual:3.49.1"


Suggested change

compileOnly "org.checkerframework:checker-qual:3.49.1"

testCompileOnly "org.checkerframework:checker-qual:3.49.1"

compileOnly "org.checkerframework:checker-qual:${versions.typetoolsVersion}"

testCompileOnly "org.checkerframework:checker-qual:${versions.typetoolsVersion}"

wmdietl · 2025-09-01T19:44:23Z

docs/examples/mismatched-checker-qual/build.gradle

+apply plugin: 'org.checkerframework'
+
+dependencies {
+    // Without the same checker qualifiers, Nullness Checker should gracefully issue warnings


Move this to the beginning of the file, where it is currently not clear what the intended behavior is.

wmdietl · 2025-09-01T19:45:12Z

docs/examples/mismatched-checker-qual/build.gradle

+
+dependencies {
+    // Without the same checker qualifiers, Nullness Checker should gracefully issue warnings
+    // Use Typetools checker-qual (original) for qualifiers


Suggested change

// Use Typetools checker-qual (original) for qualifiers

// Mismatch between `checker-qual` and `checker` artifacts.

wmdietl · 2025-09-01T19:46:17Z

docs/examples/mismatched-checker-qual/src/main/java/com/example/Demo.java

+
+public class Demo {
+    void demo(Set<Short> s, short i) {
+        s.remove(i - 1); // Error Prone error


This test doesn't use errorprone, so we can simplify this. Keep just a Nullness Checker example, for which we can test once the "graceful" behavior is implemented.

wmdietl · 2026-03-23T14:22:04Z

@thisisalexandercook Could you take over this PR (probably opening a PR from your own branch) and help get it merged?

ShahriarAhnaf and others added 3 commits July 5, 2025 14:57

eisop#1107: Adding example for wrong checker qualifier crash.

021f7bd

Cleaning up .gitignore for easier example addition with less overhead…

325cb6a

… Later

Merge branch 'master' into annotation_subpackage

5c3da59

ShahriarAhnaf marked this pull request as ready for review July 5, 2025 19:21

wmdietl requested changes Jul 6, 2025

View reviewed changes

wmdietl assigned ShahriarAhnaf Jul 6, 2025

ShahriarAhnaf and others added 5 commits July 7, 2025 18:17

Update .gitignore for organization

0cb6d74

Co-authored-by: Werner Dietl <wdietl@gmail.com>

applying changes to example name and attemping version mismatch for q…

863cc48

…ualifiers instead of dependencies

update contributers for pull request checks

a2c359c

using typetools qualifiers to cause the subpackage missing crash

42024f8

Merge branch 'master' into annotation_subpackage

45b117f

wmdietl changed the title ~~Annotation sub package crash example~~ Mismatched checker-qual artifact example Sep 1, 2025

wmdietl requested changes Sep 1, 2025

View reviewed changes

wmdietl added 2 commits January 26, 2026 20:24

Merge branch 'master' into annotation_subpackage

3a311f5

Merge branch 'master' into annotation_subpackage

444f157

	docs/examples/Wrong-Checker-Qual/Out.txt
	docs/examples/mismatched-checker-qual/Out.txt

	$(MAKE) -C mismatched-checker-qual clean
	$(MAKE) -C mismatched-checker-qual clean


		.PHONY: all clean

		ifeq ($(shell test $(JAVA_VER) -lt 17; echo $$?),0)

	eisopVersion: '3.49.3-eisop1',
	eisopVersion: '3.49.3-eisop1',
	typetoolsVersion: '3.49.1',

		compileOnly "org.checkerframework:checker-qual:3.49.1"
		testCompileOnly "org.checkerframework:checker-qual:3.49.1"

	// Use Typetools checker-qual (original) for qualifiers
	// Mismatch between `checker-qual` and `checker` artifacts.

Conversation

ShahriarAhnaf commented Jul 5, 2025 • edited by wmdietl Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShahriarAhnaf commented Jul 5, 2025

Uh oh!

wmdietl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wmdietl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wmdietl commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ShahriarAhnaf commented Jul 5, 2025 •

edited by wmdietl

Loading