fix(ci): download nginx over HTTPS and verify PGP signature (S2)#52
Merged
Conversation
tools/ci-build.sh fetched the nginx source tarball over plain HTTP, so a network attacker could swap the source that is then configured and compiled. Fetch over HTTPS, download the detached .asc, import the nginx release-signing keys from nginx.org, and gpg --verify before unpacking; fail the build on a bad or missing signature. Quote all version-derived paths. Addresses audit S2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue S2 (High — security)
tools/ci-build.shdownloaded the nginx source tarball over plainhttp://nginx.org, while resolving the version over HTTPS. A network attacker could replace the source that is then configured and compiled. This is the documented local build path.Fix
.ascsignature.https://nginx.org/keys/(tries the known signer set incl.pluknet, the current mainline signer).gpg --verifybefore unpacking; fail the build on bad/missing signature (exit code is checked directly, not masked through a pipe).Verification
Tested locally against current mainline (1.31.1):